IssueRaiser

Proposal: Update labels

This is a follow-up issue to the closed PR #18958 that was only for containers. Now that networks, volumes, images and containers all support labels, we should probably rethink the idea (or not) of having a common way to update them, instead of only being able to update containers label and no others. /cc @icecrime @tiborvass @calavera @dnephin @ehazlett Pasting @tiborvass comment from https://github.com/docker/docker/issues/20356#issuecomment-194467286 below. --- Before going into technical details, I would like to find a good UX. I could come up with these 3 solutions, none of which I really like, but I prefer the 3rd one among these: 1. For each new object type (images, networks, volumes), add a new `update` subcommand to match the `docker update` that is for containers. Questions: is there anything else we would want to update on images networks and volumes? If so what? If we can't agree on those other things to update, then the problem with this solution is we would add a new subcommand just for labels. Moreover, for historical reasons `images` is not a subcommand the way `network` and `volume` are. So if we were to still go with this solution we should also choose between: 1.a) introduce `docker images update` subcommand OR 1.b) overload `docker update` the way we (unfortunately) overload `docker inspect` and accept: `docker update --label foo=bar $imageID`. 2. Overload `docker update` to non-container objects as well. Problem: how to deal with `docker update --me

Posted by vdemeester on Apr 1, 2016, 1:06 PM

Tags

Related issues

Raise real-world problems, find people facing the same issue, and discuss solutions.5,000 issues0 comments

ux (Network)

Proposal: Update labels

vdemeesterApr 1, 2016, 1:06 PM

This is a follow-up issue to the closed PR #18958 that was only for containers. Now that networks, volumes, images and containers all support labels, we should probably rethink the idea (or not) of having a common way to update them, instead of only being able to update containers label and no others. /cc @icecrime @tiborvass @calavera @dnephin @ehazlett Pasting @tiborvass comment from https://github.com/docker/docker/issues/20356#issuecomment-194467286 below. --- Before going into technical details, I would like to find a good UX. I could come up with these 3 solutions, none of which I really like, but I prefer the 3rd one among these: 1. For each new object type (images, networks, volumes), add a new `update` subcommand to match the `docker update` that is for containers. Questions: is there anything else we would want to update on images networks and volumes? If so what? If we can't agree on those other things to update, then the problem with this solution is we would add a new subcommand just for labels. Moreover, for historical reasons `images` is not a subcommand the way `network` and `volume` are. So if we were to still go with this solution we should also choose between: 1.a) introduce `docker images update` subcommand OR 1.b) overload `docker update` the way we (unfortunately) overload `docker inspect` and accept: `docker update --label foo=bar $imageID`. 2. Overload `docker update` to non-container objects as well. Problem: how to deal with `docker update --me

Comments (0)

No comments yet. Start the discussion.

Comment on this issue