IssueRaiser

Rebase and merge pull request option should add a merge commit

Here are the options for merging pull requests: ![image](https://user-images.githubusercontent.com/504505/34022126-5662c81c-e0f2-11e7-9237-3446cb429ae4.png) Selecting the first one (Create a merge commit) will create a new merge commit so that you can easily tell that a merge was done through a pull request when you look at `git log`. The `Rebase and merge` option, however, won't create a merge commit. I think it should do so. So in other words, `Rebase and merge` should first rebase, and then do the same thing as the `Create a merge commit` option.

Posted by johnnyoshika on Dec 15, 2017, 1:17 AM

Tags

Related issues

Raise real-world problems, find people facing the same issue, and discuss solutions.4,500 issues0 comments

github (Other)

Rebase and merge pull request option should add a merge commit

johnnyoshikaDec 15, 2017, 1:17 AM

Here are the options for merging pull requests: ![image](https://user-images.githubusercontent.com/504505/34022126-5662c81c-e0f2-11e7-9237-3446cb429ae4.png) Selecting the first one (Create a merge commit) will create a new merge commit so that you can easily tell that a merge was done through a pull request when you look at `git log`. The `Rebase and merge` option, however, won't create a merge commit. I think it should do so. So in other words, `Rebase and merge` should first rebase, and then do the same thing as the `Create a merge commit` option.

Comments (0)

No comments yet. Start the discussion.

Comment on this issue