IssueRaiser

It sounds to me like there are cultural/organization issues that are very problematic and I would start the process of moving on.

It sounds to me like there are cultural/organization issues that are very problematic and I would start the process of moving on. This particular programmer is probably just the icing on the cake. That said, if what you really want to do is fix the behavior of this programmer here is my suggestion: - Institute mandatory code reviews for all commits for everybody. There are any number of great tools for facilitating this and it is good practice anyway. Not everyone has to approve every commit, but at least 1 person must thumbs up before it can be merged. - On this particular programmers commit, you have to code review and comment on everything. Say things like "strongly typed objects are idiomatic C# code, we should follow that" or "this seems like it might have performance problems" or "hey I'd do that 'this way'". - If this is problematic, institute code standards for the whole team . Have the terrible bike shed discussions and make him make his bad way the standard for everyone if he wants it. This will enlist others in your cause (and probably make him realize how bad what he is doing is) - Don't let other people fix the bugs he introduces. As soon as you find one, document it and give it to him to fix. If the ORM is not providing value, his argument is valid, but likely he is arbitraging the pain of using the ORM initially by making others maintain his nonsense. Don't let him do that. Four things can happen if you do this: - he gets tired of the crap and quits - he gets tired of the crap and gets you fired/to quit. - he gets better - he never gets better but the code isn't impacted and you make it obvious to everyone on the team what a drag he is.

Posted by kasey_junk on May 30, 2015, 1:59 AM

Tags

Related issues

Raise real-world problems, find people facing the same issue, and discuss solutions.6,000 issues0 comments

hackernews (Other)

It sounds to me like there are cultural/organization issues that are very problematic and I would start the process of moving on.

kasey_junkMay 30, 2015, 1:59 AM

It sounds to me like there are cultural/organization issues that are very problematic and I would start the process of moving on. This particular programmer is probably just the icing on the cake. That said, if what you really want to do is fix the behavior of this programmer here is my suggestion: - Institute mandatory code reviews for all commits for everybody. There are any number of great tools for facilitating this and it is good practice anyway. Not everyone has to approve every commit, but at least 1 person must thumbs up before it can be merged. - On this particular programmers commit, you have to code review and comment on everything. Say things like "strongly typed objects are idiomatic C# code, we should follow that" or "this seems like it might have performance problems" or "hey I'd do that 'this way'". - If this is problematic, institute code standards for the whole team . Have the terrible bike shed discussions and make him make his bad way the standard for everyone if he wants it. This will enlist others in your cause (and probably make him realize how bad what he is doing is) - Don't let other people fix the bugs he introduces. As soon as you find one, document it and give it to him to fix. If the ORM is not providing value, his argument is valid, but likely he is arbitraging the pain of using the ORM initially by making others maintain his nonsense. Don't let him do that. Four things can happen if you do this: - he gets tired of the crap and quits - he gets tired of the crap and gets you fired/to quit. - he gets better - he never gets better but the code isn't impacted and you make it obvious to everyone on the team what a drag he is.

Comments (0)

No comments yet. Start the discussion.

Comment on this issue