Support prettier-ignore-start/end for other languages (not only Markdown)

It seems this feature was added only for markdown (#4202 cc @ikatyang), but it's actually useful for other languages as well. It is not working on typescript files on my tests. Related: https://github.com/facebook/create-react-app/issues/5543 **Environments:** - Prettier Version: 1.14.3 - Running Prettier via: CLI - Runtime: Node.js v8.11.4 - Operating System: macOS **Steps to reproduce:** Create a `index.d.ts` file with the following content: ```ts // prettier-ignore type A1 = string; // prettier-ignore type A2 = string /* prettier-ignore-start */ type B1 = string; type B2 = string /* prettier-ignore-end */ type C1 = string; type C2 = string ``` **Expected behavior:** ```diff // prettier-ignore type A1 = string; // prettier-ignore type A2 = string /* prettier-ignore-start */ type B1 = string; type B2 = string /* prettier-ignore-end */ -type C1 = string; +type C1 = string type C2 = string ``` **Actual behavior:** ```diff // prettier-ignore type A1 = string; // prettier-ignore type A2 = string /* prettier-ignore-start */ -type B1 = string; +type B1 = string type B2 = string /* prettier-ignore-end */ -type C1 = string; +type C1 = string type C2 = string ```

Posted by brunolemos on Oct 23, 2018, 2:56 PM

Tags

• support (SaaS)

Related issues

• I hate that this whole cluster of beliefs exists, but software on my own computer enforcing what I can and can't do for ideological reaso...
• As I replied in another comment[1], it's their software, their choice.
• [Feature] Support external model integration via personal API keys and local LLMs (BYOK)
• > So when head of companies don’t care about quality, they’ll push hard no matter what to have speed.
• Feature request: support multiple named accounts per app/connector
• Support standalone Windows installer (`codex-setup.exe`)