Add support for diagnostic severities

TypeScript has added compiler options for lint level checks like `noUnusedParameters` or `noUnusedLocals` in tsconfig.json (which is goodness). Today when such an option is enabled then the corresponding issues are reported by TypeScript in the same way as semantic or syntax errors. There is no notion of severity. ## Background We are using tslint to develop VS Code and we have used tslint rules to detect unused locals. TSLint rule failures are reported in VS code as warnings and we had the setup that lint style issue are shown as warnings and the typescript issues (syntax, semantic) are shown as errors. Now that typescript added more lint style checks we no longer get the distinction when developing between lint level warnings and semantic errors. The situation has become worse with tslint 4.0, there tslint has started to deprecate rules which are covered by TypeScript compiler options. This makes good sense, but it means we are now starting to see 'unused locals' reported as errors and no longer as warnings as we did before. ## Suggestion Support that the user can define in the tsconfig.json whether a check enabled by compiler option should be reported as `error` or `warning`. `eslint` supports to configure the severity of an option. Here is an example the [eslint documentation](http://eslint.org/docs/user-guide/configuring): ```json { "rules": { "eqeqeq": "off", "curly": "warn", "quotes": ["error", "double"] } } ``` // CC @waderyan @m

Posted by egamma on Jan 11, 2017, 10:52 AM

Tags

• support (Software)

Related issues

• Add 65536 size support for maps
• TypeScript 7.1 Iteration Plan
• nvim-treeconfig: upstream nvim-treesitter
• Add the "action" and "method" attributes to <button>
• [FEATURE] Support multiple Connector accounts (same connector, different accounts) in Claude and Claude Code on the web (claude.ai/code)
• > We were imposed GitHub for so many exercises!