Mark pull request as depending on another
Quite often I find myself raising a pull request that contains another within it as a dependency. I want the diff to be exclusive of the dependency pull request’s changes, otherwise my colleagues end up reviewing more than they need to, or worse, the same changes twice (in both pull requests). To workaround this, I usually set the base of my pull request to the dependency pull request, however this has caveats: - When the dependency pull request is merged and the branch is deleted, the dependent pull request will be automatically closed. - When the dependent pull request is merged, it is silently merged into the dependency pull request. This is usually not intentional. I would like to see some UI in GitHub to make this workflow first class: - Dependent pull requests should not be mergeable until all dependency pull requests have been merged
Posted by OliverJAsh on Jun 14, 2017, 4:50 PM
Tags
Related issues
- This is the biggest problem with contracts, there's simply no way to actually say "please always execute this check".
- I don't disagree with you on this, I worked my whole life in corporate and haven't worked as a OSS maintainer before, though I will _and ...
- the new VSCode UI, looks cute, i don't like it.
- I've been working on my own private harness for the past 8 months, and I've been collecting ideas from such repos I've stumbled upon.
- The way AI is able to interact with outside resources is pretty impressive, but the quality of code it produces to me is still questionab...
- Add PR-style review comments in Git Diff UI that feed into the active agent thread
Raise real-world problems, find people facing the same issue, and discuss solutions.4,500 issues0 comments
ux (Software)
This is the biggest problem with contracts, there's simply no way to actually say "please always execute this check".
I don't disagree with you on this, I worked my whole life in corporate and haven't worked as a OSS maintainer before, though I will _and ...
the new VSCode UI, looks cute, i don't like it.
I've been working on my own private harness for the past 8 months, and I've been collecting ideas from such repos I've stumbled upon.
The way AI is able to interact with outside resources is pretty impressive, but the quality of code it produces to me is still questionab...
Add PR-style review comments in Git Diff UI that feed into the active agent thread
Thanks for indulging me so far, by the way, I really appreciate this discussion, it's very stimulating.
Migrate GDScript to the GDExtension mechanism and overhaul the implementation
Mark pull request as depending on another
Quite often I find myself raising a pull request that contains another within it as a dependency. I want the diff to be exclusive of the dependency pull request’s changes, otherwise my colleagues end up reviewing more than they need to, or worse, the same changes twice (in both pull requests). To workaround this, I usually set the base of my pull request to the dependency pull request, however this has caveats: - When the dependency pull request is merged and the branch is deleted, the dependent pull request will be automatically closed. - When the dependent pull request is merged, it is silently merged into the dependency pull request. This is usually not intentional. I would like to see some UI in GitHub to make this workflow first class: - Dependent pull requests should not be mergeable until all dependency pull requests have been merged
Comments (0)
No comments yet. Start the discussion.