IssueRaiser

Combine workspace trust with enablePromptUseWorkspaceTsdk

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Describe the feature you'd like. --> Related: https://github.com/microsoft/vscode/issues/65546#issuecomment-617937038 https://github.com/microsoft/vscode/issues/65546 https://github.com/microsoft/vscode/issues/30069#issuecomment-312732928 Now that we have workspace trust feature in VSCode. The separate prompt of `enablePromptUseWorkspaceTsdk` felt somewhat redundant. Can we automatically honor `typescript.tsdk` in workspace setting when user already trust the workspace? This doesn't regress on security and makes distributing `typescript.tsdk` among our large developer user base much easier. Actually I would prefer if it can be enforced because we have 500 developers and "my enlistment doesn't work" - "oh wrong TS was selected" came up several times every month. And people usually tolerance the issue for quite some time before they reach out for help, slowing down their daily development work in the meantime. @mjbvz

Posted by ccstr on Oct 24, 2021, 1:23 AM

Tags

Related issues

Raise real-world problems, find people facing the same issue, and discuss solutions.3,000 issues0 comments

reliability (Software)

Combine workspace trust with enablePromptUseWorkspaceTsdk

ccstrOct 24, 2021, 1:23 AM

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Describe the feature you'd like. --> Related: https://github.com/microsoft/vscode/issues/65546#issuecomment-617937038 https://github.com/microsoft/vscode/issues/65546 https://github.com/microsoft/vscode/issues/30069#issuecomment-312732928 Now that we have workspace trust feature in VSCode. The separate prompt of `enablePromptUseWorkspaceTsdk` felt somewhat redundant. Can we automatically honor `typescript.tsdk` in workspace setting when user already trust the workspace? This doesn't regress on security and makes distributing `typescript.tsdk` among our large developer user base much easier. Actually I would prefer if it can be enforced because we have 500 developers and "my enlistment doesn't work" - "oh wrong TS was selected" came up several times every month. And people usually tolerance the issue for quite some time before they reach out for help, slowing down their daily development work in the meantime. @mjbvz

Comments (0)

No comments yet. Start the discussion.

Comment on this issue